Re: [PATCH] wireless: fix supported cards for rtl8187

[Hin-Tak Leung]

On Wed, Jul 8, 2009 at 11:18 PM, Marcin Slusarz<marcin.slusarz@xxxxxxxxx> wrote:
> Hin-Tak Leung wrote:
>> Is there a v1, and what does it use?
>
> I don't know.

2009/7/8 Gábor Stefanik <netrolller.3d@xxxxxxxxx>:
> On Wed, Jul 8, 2009 at 11:49 PM, Hin-Tak Leung<hintak.leung@xxxxxxxxx> wrote:
>> Is there a v1, and what does it use?
>
> I have the v1, it is rt73-based. (v3 is rt2070, not rt3070, though.)

I guess I have two questions: (1) are the 3 variants labelled in that
way as such v1/v2/v3 (on the box,
or one of the USB device identity queries)? (2) are they distinguished
by different product IDs?

The point is that the commit (which only changes the help message) is
only appropriate if they are labelled as v1/v2/v3 and not
distinguished by different product IDs. If they are distinguished by
different product IDs and the current codes for the three drivers bind
correctly to each, then the change is only relevant to people who
manually build their kernel and want to build one driver but not the
others. (i.e. instead of distros which ship the full set of driver
modules). Which goes to my first question...

if they are not labelled v1/v2/v3 as such, it may be more
useful/informative to change to

    [some variant of ] ... [(other variants are supported by the
rt2070/rt3070 modules)]

instead of just adding [v2] to the end.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/