Re: [PATCH] This is the security processor driver for the Intel midplatform

From: James Morris
Date: Wed Jul 08 2009 - 21:19:36 EST


On Thu, 9 Jul 2009, Alan Cox wrote:

> On Wed, 8 Jul 2009 13:01:02 -0700
> Mark Allyn <mark.a.allyn@xxxxxxxxx> wrote:
>
> > This is the driver for the Security Processor (SEP) for the Intel MID Platform.
> >

> Whats a SEP ? (I know that but I work for Intel ;)). This needs a longer
> text and a description that would be useful to more people. The one in
> your intro text is probably pretty close.

Also, please cc the linux-security-module list with security related code,
and also possibly the crypto list
(see http://vger.kernel.org/vger-lists.html)

Here's the output of checkpatch.pl with your patch:

total: 15 errors, 29 warnings, 4 checks, 5737 lines checked

The errors need to be fixed or justified; see section 4 of
Documentation/SubmittingPatches.


- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/