Re: [PATCH 1/6] atmel-mci: Unified Atmel MCI drivers (AVR32 & AT91)

[Nicolas Ferre]

Haavard Skinnemoen :
> Nicolas Ferre wrote:
>>> -#define ATMCI_DATA_ERROR_FLAGS	(MCI_DCRCE | MCI_DTOE | MCI_OVRE | MCI_UNRE)
>>> +#define ATMCI_DATA_ERROR_FLAGS	(MCI_RINDE | MCI_RDIRE | MCI_RCRCE  \
>>> +				 | MCI_RENDE | MCI_RTOE | MCI_DCRCE \
>>> +				 | MCI_DTOE | MCI_OVRE | MCI_UNRE)  
>> Haavard, is it ok to add those flags on an AVR32 platform for now ?
> 
> It probably doesn't hurt on AVR32. But I'm not a great fan since it
> seems like the wrong thing to do, and it may simply mask the real
> problem.

Agreed.

To move forward, I will submit a first patch series without those flags
added.

Best regards,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/