Re: [PATCH 3/3] net-dccp: Suppress warning about large allocationsfrom DCCP

From: David Miller
Date: Mon Jun 22 2009 - 19:15:18 EST


From: Mel Gorman <mel@xxxxxxxxx>
Date: Mon, 22 Jun 2009 16:43:34 +0100

> The DCCP protocol tries to allocate some large hash tables during
> initialisation using the largest size possible. This can be larger than
> what the page allocator can provide so it prints a warning. However, the
> caller is able to handle the situation so this patch suppresses the warning.
>
> Signed-off-by: Mel Gorman <mel@xxxxxxxxx>

It's probably much more appropriate to make this stuff use
alloc_large_system_hash(), like TCP does (see net/ipv4/tcp.c
tcp_init()).

All of this complicated DCCP hash table size computation code will
simply disappear. And it'll fix the warning too :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/