Re: [PATCH -rt] disable building all staging drivers

From: Greg KH
Date: Mon Jun 22 2009 - 16:56:55 EST


On Mon, Jun 22, 2009 at 11:06:04AM -0700, Daniel Walker wrote:
> On Mon, 2009-06-22 at 10:19 -0700, Greg KH wrote:
> > On Mon, Jun 22, 2009 at 05:15:15PM +0200, Uwe Kleine-König wrote:
> > > Hi Greg,
> > >
> > > On Mon, Jun 15, 2009 at 01:00:44AM +0200, Uwe Kleine-König wrote:
> > > > On Sun, Jun 14, 2009 at 04:28:02AM -0700, Greg KH wrote:
> > > > > On Sat, Jun 13, 2009 at 11:38:38PM +0200, Uwe Kleine-König wrote:
> > > > > > I know that at least COMEDI and RT2870 are broken with -rt,
> > > > >
> > > > > I didn't know this, has anyone sent me a bug report? What in -rt causes
> > > > > these drivers to break?
> > > > >
> > > > > > but Thomas requested disabling all of staging. He's the maintainer.
> > > > >
> > > > > This seems like a patch to ensure that the staging drivers never get a
> > > > > chance to be fixed for any potential -rt issues. How about just sending
> > > > > me bug reports instead?
> > > > I cannot reproduce the failure I saw for RT2870 at the moment.
> > > OK, hit again:
> > >
> > > 17:02:43 E: ERROR: "there_is_no_init_MUTEX_LOCKED_for_RT_semaphores" [drivers/staging/rt2870/rt2870sta.ko] undefined!
> >
> > What needs to be done in the rt2870 driver to resolve this issue?
>
> The semaphore needs to be converted to a completion. Or the code needs
> to be re-worked so it can use a mutex.

Patches gladly accepted :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/