Re: [PATCH] parport_pc: after superio probing restore originalregister values

From: Alan Cox
Date: Mon Jun 15 2009 - 17:57:28 EST


On Mon, 15 Jun 2009 19:33:52 +0200
Jens Rottmann <JRottmann@xxxxxxxxxxxxxxxxxx> wrote:

> CONFIG_PARPORT_PC_SUPERIO probes for various superio chips by writing
> byte sequences to a set of different potential I/O ranges. But the
> probed ranges are not exclusive to parallel ports. Some of our boards
> just happen to have a watchdog in one of them. Took us almost a week
> to figure out why some distros reboot without warning after running
> flawlessly for 3 hours. For exactly 170 = 0xAA minutes, that is ...

Ouch - that must have been a pig to find.

> Fixed by restoring original values after probing. Also fixed too small
> request_region() in detect_and_report_it87().
>
> Signed-off-by: Jens Rottmann <JRottmann@xxxxxxxxxxxxxxxxxx>

Will queue for Linus

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/