Re: [PATCH 2/2] sched: use slab in cpupri_init()

[Li Zefan]

Pekka Enberg wrote:
> Hi Li!
> 
> On Thu, 2009-06-11 at 14:10 +0800, Li Zefan wrote:
>>> @@ -163,9 +167,7 @@ int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
>> so the __init_refok tag can be removed, no?
> 
> I am not sure how this is related to my patch but as long as
> init_rootdomain() has it, cpupri_init() should too AFAICT.
> 

cpupri_init() is marked as __init_refok, because it calls
alloc_bootmem_cpumask_var() not because init_rootdomain()
has the tag. Now this patch removes this function call,
so the tag is no long needed.

> 
>>>  
>>>  		spin_lock_init(&vec->lock);
>>>  		vec->count = 0;
>>> -		if (bootmem)
>>> -			alloc_bootmem_cpumask_var(&vec->mask);
>>> -		else if (!zalloc_cpumask_var(&vec->mask, GFP_KERNEL))
>>> +		if (!zalloc_cpumask_var(&vec->mask, gfp))
>>>  			goto cleanup;
>>>  	}
>>>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/