Re: [PATCH 2/9] SPI: xilinx_spi: Added platform driver and supportfor DS570

From: Andrew Morton
Date: Wed Jun 10 2009 - 04:58:41 EST


On Wed, 10 Jun 2009 10:48:58 +0200 Richard R__jfors <richard.rojfors.ext@xxxxxxxxxxxxxxx> wrote:

> On 09-06-10 01.09, Andrew Morton wrote:
> > On Fri, 05 Jun 2009 15:40:19 +0200
> > Richard R__jfors <richard.rojfors.ext@xxxxxxxxxxxxxxx> wrote:
> >
> >> This patch splits xilinx_spi into three parts, an OF and a platform
> >> driver and generic part.
> >>
> >> The generic part now also works on X86 and also supports the Xilinx
> >> SPI IP DS570
> >
> > Unfortunately we already have two fairly significant
> > drivers/spi/xilinx_spi.c patches queued in -mm:
> > spi-move-more-spi_setup-functionality-into-core.patch and
> > spi-move-common-spi_setup-functionality-into-core.patch. Applying this
> > patch on top of those makes rather a mess.
> >
> > Hopefully things will still be OK if I skip this patch. You didn't
> > identify the dependencies between those nine patchs. Can you please
> > explain that?
>
> Actually all patches except for the 7th(of 9), would work without the
> xilinx_spi-patch.
> The 7th (Timberdale MFD) would not build. Some of the othe drivers are not
> possible to select because they depend on the MFD in their Kconfigs,
> but not the code.

Confused.

See, my problem is that normally I will hold off on sending a patch to
its subsystem maintainer until its prerequisite patch(es) are in mainline.
But for each of these patches, I don't know what the exact prerequisites
are. Help?

(The simple alternative is for me to seek acks and merge them all
myself. But sometimes getting those acks is hard).

> I would be very happy if you applied all but the 7th (MFD) and 2nd (SPI) anyway.
>
> I will update my SPI-patch to work against the two patches you point out above.
> And them I will resend the Timberdale MFD and the Xilinx SPI patch.
>
> Would that be OK?

That would be great, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/