Re: linux-next: net tree build warning

From: Wolfgang Grandegger
Date: Tue Jun 09 2009 - 07:25:44 EST


Hello,

Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (powerpc allyesconfig) produced these warnings:
>
> drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_probe':
> drivers/net/can/sja1000/sja1000_of_platform.c:111: warning: format '%#x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
> drivers/net/can/sja1000/sja1000_of_platform.c:111: warning: format '%#x' expects type 'unsigned int', but argument 5 has type 'resource_size_t'
> drivers/net/can/sja1000/sja1000_of_platform.c:118: warning: format '%#x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'
> drivers/net/can/sja1000/sja1000_of_platform.c:118: warning: format '%#x' expects type 'unsigned int', but argument 5 has type 'resource_size_t'
>
> Introduced by commit d1a277c584d0862dbf51991baea947ea5f2ce6bf ("can:
> sja1000: generic OF platform bus driver").

The patch below should fix the build problems (which I cannot
reproduce on my test systems).

Thanks,

Wolfgang.

-----------------------------------------------------------------------
[PATCH] can: sja1000_of_platform: fix build problems with printk format

Variables of type size_t should be printed with the format "%zx".

Signed-off-by: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>
---
drivers/net/can/sja1000/sja1000_of_platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: net-next-2.6/drivers/net/can/sja1000/sja1000_of_platform.c
===================================================================
--- net-next-2.6.orig/drivers/net/can/sja1000/sja1000_of_platform.c 2009-06-09 12:45:38.000000000 +0200
+++ net-next-2.6/drivers/net/can/sja1000/sja1000_of_platform.c 2009-06-09 13:06:56.495718952 +0200
@@ -108,14 +108,14 @@
res_size = resource_size(&res);

if (!request_mem_region(res.start, res_size, DRV_NAME)) {
- dev_err(&ofdev->dev, "couldn't request %#x..%#x\n",
+ dev_err(&ofdev->dev, "couldn't request %#zx..%#zx\n",
res.start, res.end);
return -EBUSY;
}

base = ioremap_nocache(res.start, res_size);
if (!base) {
- dev_err(&ofdev->dev, "couldn't ioremap %#x..%#x\n",
+ dev_err(&ofdev->dev, "couldn't ioremap %#zx..%#zx\n",
res.start, res.end);
err = -ENOMEM;
goto exit_release_mem;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/