Re: [patch] r8169: fix crash when large packets are received

From: David Miller
Date: Tue Jun 09 2009 - 07:01:30 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Tue, 09 Jun 2009 00:07:07 +0200

> Michael Tokarev reported receiving a large packet could crash
> a machine with RTL8169 NIC.
> ( original thread at http://lkml.org/lkml/2009/6/8/192 )
>
> Problem is this driver tells that NIC frames up to 16383 bytes
> can be received but provides skb to rx ring allocated with
> smaller sizes (1536 bytes in case standard 1500 bytes MTU is used)
>
> When a frame larger than what was allocated by driver is received,
> dma transfert can occurs past the end of buffer and corrupt
> kernel memory.
>
> Fix is to tell to NIC what is the maximum size a frame can be.
>
> This bug is very old, (before git introduction, linux-2.6.10), and
> should be backported to stable versions.
>
> Reported-by: Michael Tokarev <mjt@xxxxxxxxxx>
> Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Tested-by: Michael Tokarev <mjt@xxxxxxxxxx>

Applied to net-2.6, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/