Re: broken ide-tape

[Borislav Petkov]

On Sun, May 31, 2009 at 04:52:08PM +0200, Jiri Slaby wrote:
> Hi,
> 
> ide-tape is broken since commit 346331f82823682fb5c2df6e827db25d95cc2e92
> (ide-tape: remove atomic test/set macros for packet commands)
> from Apr 18 2008.
> 
> The commit introduced flags which are defined as (1 << nr) and uses them
> in {clear,set,test}_bit. And hence it must oops on each do_request.

/me ducks behind the couch.

Ouch, that _is_ dumb, sorry. This is because we wanted to keep the
atomic ops for the pipeline handling (which got removed) and use
simple flags for the rest. And so the flags got mixed up and the mess
unleashed...

> Is it worth fixing (something like ilog2 added to each bit operation) or
> is a complete removal of the driver better "fix"?

Actually, the driver needs to be reaudited and fixed properly - we still
have some users left. I'm looking into it.

Thanks for catching that.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/