Re: [PATCH 2/5] mmc: tmio_mmc: add bus_shift support

From: pHilipp Zabel
Date: Sat May 30 2009 - 07:45:22 EST


On Sat, May 30, 2009 at 12:36 PM, Ian molton <spyro@xxxxxxx> wrote:
> pHilipp Zabel wrote:
>>
>> On Mon, May 25, 2009 at 9:27 PM, Philipp Zabel <philipp.zabel@xxxxxxxxx>
>> wrote:
>>>
>>> Some ASIC3 devices in the wild are connected with the address bus shifted
>>> by one line, so that its 16-bit registers appear 32-bit aligned in host
>>> memory space.
>>
>> This patch has to be amended:
>
> I have to assume that this works - I have no asic3 hardware, and bus shift
> is zero on TMIO hardware, so this didnt cause issues.
>
> This modification acked too.

Thanks. Actually, I only have bus_shift = 0 hardware, too (hx4700 and
blueangel).

According to http://wiki.xda-developers.com/index.php?pagename=ASIC3,
himalaya and the iPAQs h4xxx, h19xx, h39xx and rx37xx have the shift.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/