Re: [PATCH] 8250: Fix oops from setserial

From: Alan Cox
Date: Sat May 30 2009 - 06:45:41 EST


> Sure, huge numbers of drivers use the cast.
>
> But I've never seen past sinnings as being a reason to continue sinning.
> Doing new code the right way doesn't result in worse code, and reduces
> the chances of someone copying and pasting the wrong way.

As I said please read the rest of the driver. It would ridiculous to have
one dereference done differently to the rest in several thousand lines of
code.

It's not a new driver, it's simply pasting a line from one place to
another to update a field.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/