Re: [PATCH] 8250: Fix oops from setserial

From: Alan Cox
Date: Sat May 30 2009 - 04:25:38 EST


>
> > static void set_io_from_upio(struct uart_port *p)
> > {
> > + struct uart_8250_port *up = (struct uart_8250_port *)p;
>
> container_of() is nicer, IMO. It's clearer, and doesn't require that
> the uart_port be the fist member.

See the rest of the driver - it was written that way years ago and this
is just following the existing design.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/