Re: [alsa-devel] [PATCH] ALSA: clean up the logic for building sequencer modules

From: Takashi Iwai
Date: Fri May 29 2009 - 05:53:36 EST


At Wed, 27 May 2009 23:14:00 +0200,
I wrote:
>
> At Tue, 26 May 2009 17:07:52 +0200,
> Michal Marek wrote:
> >
> > Instead of mangling the CONFIG_* variables in the makefiles over and
> > over, set a few helper variables in Kconfig.
> >
> > Signed-off-by: Michal Marek <mmarek@xxxxxxx>
>
> Thanks for the patch.
>
> Well, I've been thinking of clean-up of these, but my idea was to
> define rather a symbol for each possible module instead of the
> intermediate defines as your patch. That is, selecting the component
> from the driver side, e.g. select SND_EMU10K1_SYNTH, SND_SEQ_MIDI_EVENT,
> etc from SND_EMU10K1 config.
>
> But, achieving it with the current kconfig seems complex, so I stopped
> it once after a bad result.
>
> I'll reconsider whether it's possible, and will apply your patch if
> it's hard / impossible :)

As I see no easy way to achieve it, I applied your patch now.

Thanks!


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/