Re: [PATCH 2.6.30 2/2] cxgb3: link fault fixes

From: David Miller
Date: Fri May 29 2009 - 04:57:22 EST


From: Divy Le Ray <divy@xxxxxxxxxxx>
Date: Thu, 28 May 2009 14:23:08 -0700

> From: Divy Le Ray <divy@xxxxxxxxxxx>
>
> Do not call t3_link_fault() under spinlock, as it calls msleep().
> Besides, only the access to pi->link_fault needs to be serialized.
>
> Also initialize local variables before checking the link status,
> link state fields might otherwise end up containing garbage.
>
> Signed-off-by: Divy Le Ray <divy@xxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/