Re: [PATCH] IB/mthca: replace dma_sync_single withdma_sync_single_for_cpu

[FUJITA Tomonori]

On Thu, 28 May 2009 15:18:21 -0700
Roland Dreier <rdreier@xxxxxxxxx> wrote:

>  > This replaces dma_sync_single() with dma_sync_single_for_cpu() because
>  > dma_sync_single() is an obsolete API; include/linux/dma-mapping.h says:
>  > 
>  > /* Backwards compat, remove in 2.7.x */
> 
> Thanks for pointing this out... however I think sync_single_for_cpu
> looks wrong in these cases -- I think there should be a pair of
> sync_single_for_cpu/sync_single_for_device around this stuff.

Yeah, possibly. I just convert it without looking at the code. As you
know, the patch will not change anything. If dma_sync_single_for_cpu
doesn't work here, the driver is already broken.


> I'll take a closer look in the next day or too.

Cool, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/