Re: [PATCH] regulator/max1586: fix V3 gain calculation integer overflow

[Robert Jarzmik]

Philipp Zabel <philipp.zabel@xxxxxxxxx> writes:

> On Thu, May 28, 2009 at 10:59 AM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> On Thu, May 28, 2009 at 07:15:16AM +0200, Philipp Zabel wrote:
>>> The V3 regulator can be configured with an external resistor
>>> connected to the feedback pin (R24 in the data sheet) to
>>> increase the voltage range.
>>>
>>> For example, hx4700 has R24 = 3.32 kOhm to achieve a maximum
>>> V3 voltage of 1.55 V which is needed for 624 MHz CPU frequency.
>>>
>>> Signed-off-by: Philipp Zabel <philipp.zabel@xxxxxxxxx>
>>
>> Looks good.
>>
>> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Thanks, but it turns out I hit a 32 bit integer overflow in
> the gain calculation. I'd like to mend that with the following
> patch. Now max_uV could be increased up to 4.294 V, enough to
> charge LiPo cells.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@xxxxxxxxx>
OK.

With that one melt into the previous one, have my :
Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Would you submit that to Liam or Mark for queuing into the regulator patch queue ?

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/