Re: [PATCH v6] cciss: add cciss driver sysfs entries

From: Mike Miller (OS Dev)
Date: Thu May 28 2009 - 16:24:51 EST


On Mon, Apr 13, 2009 at 10:45:25AM -0600, Andrew Patterson wrote:
This is version six of my patch to add sysfs entries to the cciss driver.

Changelog:

Version 3
Got rid of /sys/class/cciss_* entries. Now only show vendor, model,
rev, and unique_id at /sys/bus/pci/devices/ccissX/cXdY. Where X is the
controller nubmer and Y is the logical drive number.
Fixed a double memcpy of the serial number.
Documented new sysfs entries in
Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
Fixed tabs in Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
Removed unneeded device_attribute release functions
Fixed pahole-reported holes.

Version 4
Moved cciss_sysfs.c into cciss.c
Added cciss_bus_type to logical drive so we get /sys/bus/cciss/device/ccissX.

Version 5
Added cciss_bus_type to hba so we get /sys/bus/cciss/device/cYdZ.

Version 6

Use "sizeof() + 1" instead of "*LEN + 2" for *_show() routines.
Added back in ABI docs.
The following patch adds sysfs entries for the cciss driver. It adds
vendor, model, rev, and unique_id under /sys/block/cciss!c#d#/device
needed for RedHat BZ:

https://bugzilla.redhat.com/show_bug.cgi?id=484419

This patch is based off os linus's 2.6 tree (2.6.30-rc1).

.../ABI/testing/sysfs-bus-pci-devices-cciss | 33 ++
drivers/block/cciss.c | 267 ++++++++++++++++++++
drivers/block/cciss.h | 24 +-
3 files changed, 314 insertions(+), 10 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-cciss


--
Andrew Patterson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/