Re: [PATCH] tracing/lockdep: report the time waited for a lock

[Peter Zijlstra]

On Thu, 2009-05-28 at 10:32 -0400, Steven Rostedt wrote:

> > +	TP_STRUCT__entry(
> > +		__field(const char *, name)
> > +		__field(unsigned long, wait_usec)
> > +		__field(unsigned long, wait_nsec_rem)
> > +	),
> > +	TP_fast_assign(
> > +		__entry->name = lock->name;
> > +		__entry->wait_nsec_rem = do_div(waittime, NSEC_PER_USEC);
> 
> I know this is already accepted, but can you move the do_div into the 
> print section.

please do. Just fold those wait_* fields into a single u64 nsec one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/