Re: [PATCH] x86: MCE: Fix for mce_panic_timeout

[Hidetoshi Seto]

Andi Kleen wrote:
> Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> writes:
>>  - In case of panic_timeout > 0 and mce_bootlog == 0.
>>    System should reboot after panic, but it doesn't on mce panic because
>>    current mce code overwrite panic_timeout to 0.
> 
> Nope, with bootlog==0 it should _not_ automatically reboot on panic.
> Automatic rebooting makes mainly sense with boot logging, otherwise
> you will likely lose the information. Or at least the kernel 
> cannot know if you lose information or not so it has to err on 
> the safe side.

Users already know they might lose the information about the panic
if panic_timeout > 0.  It is same on all kind of panic.

> I changed it now to only override with panic_timeout == 0,
> as in the user didn't set anything,
> that's probably the most sensible semantics anyways.

It's OK with me.
The logic in this patch also seems good.

But...

> v2: Only force panic timeout when it's shorter (H.Seto)
> v3: Only panic when there is no earlier timeout or it's not zero
> (based on comment H.Seto)

"Only panic when ..." ?
I could not cache the meaning of this changelog.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/