Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

From: Becky Bruce
Date: Wed May 27 2009 - 18:12:26 EST



On May 27, 2009, at 3:29 PM, Ian Campbell wrote:

On Wed, 2009-05-27 at 15:05 -0400, Becky Bruce wrote:
On May 22, 2009, at 6:11 AM, Ian Campbell wrote:


BTW do you need swiotlb_bus_to_virt to be __weak or is the fact that
it
is implemented in terms of swiotlb_bus_to_phys sufficient?

The default one in swiotlb calls phys_to_virt on the result of
swiotlb_bus_to_phys, which only works on lowmem.

Perhaps we can simply enhance the default one to handle highmem instead
of making it arch specific?

That's fine by me - as long as what I've got will work for you guys I'm happy to stick it in the standard one (inside a nice pretty #ifdef CONFIG_HIGHMEM, of course).

Cheers,
B
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/