Re: [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings

[Herbert Xu]

On Wed, May 20, 2009 at 06:56:23PM +0400, Evgeniy Polyakov wrote:
> Hi Mike.
> 
> On Mon, May 18, 2009 at 03:51:50AM -0400, Mike Frysinger (vapier@xxxxxxxxxx) wrote:
> > The remove member of the pci_driver hifn_pci_driver uses __devexit_p(),
> > so the remove function itself should be marked with __devexit.  And where
> > there be __devexit on the remove, so is there __devinit on the probe.
> > 
> > Similarly, the module_init/module_exit functions should be declared with
> > plain __init/__exit markings, not the hotplug __dev{init,exit} ones.
> > 
> > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> > CC: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
> > CC: Patrick McHardy <kaber@xxxxxxxxx>
> 
> Looks good, thank you Mike.
> Ack. Herbert, please apply.

Applied to cryptodev.  Thanks a lot!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/