Re: [PATCH v2 1/2] tracing/events: make __string() more general

From: Li Zefan
Date: Tue May 26 2009 - 21:42:30 EST


Christoph Hellwig wrote:
> On Tue, May 26, 2009 at 12:04:28PM +0800, Li Zefan wrote:
>> This changes __string(..., src) to __string(..., len), thus makes it more
>> general, and then block TRACE_EVENT() can use it.
>>
>> Also introduce __fetch_str(), which is used in TP_assign() and returns
>> the address of the string, while __get_str() is used in TP_print().
>
> If you want to make it really generaly dealing with NULL string pointers
> would be extremly helpful. I ran into that limitation (and the length
> one fixed here) when converting the XFS tracing over.
>

I'm not suffering from NULL str, so I'm not quite sure how you want __string()
deal with it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/