[PATCH 07/31] x86: MCE: Log corrected errors when panicing

From: Andi Kleen
Date: Tue May 26 2009 - 19:56:19 EST


From: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Impact: bugfix

Normally the machine check handler ignores corrected errors and leaves
them to machine_check_poll(). But when panicing mcp won't run, so
log all errors.

Note: this can still miss some cases until the "early no way out"
patch later is applied too.

Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
---
arch/x86/kernel/cpu/mcheck/mce.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index d2d7a68..d379e3f 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -398,9 +398,9 @@ void do_machine_check(struct pt_regs *regs, long error_code)

/*
* Non uncorrected errors are handled by machine_check_poll
- * Leave them alone.
+ * Leave them alone, unless this panics.
*/
- if ((m.status & MCI_STATUS_UC) == 0)
+ if ((m.status & MCI_STATUS_UC) == 0 && !no_way_out)
continue;

/*
--
1.6.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/