Re: [2.6.27.24] Kernel coredump to a pipe is failing

[Andrew Morton]

On Wed, 27 May 2009 01:14:28 +0200
Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> On Tue, May 26, 2009 at 04:00:17PM -0700, Andrew Morton wrote:
> > dump_write() doesn't seem right, either.  If ->write() returns, say,
> > 100 then the dump should keep on going.  At present it treats this
> > return as an error.
> 
> I think that's correct actually. Short write typically means serious 
> issue like disk full or broken pipe, so stopping is good.

But we shouldn't assume that.  It could be that the ->write
implementation is perfectly able to absorb the remaining data.

We should only error out of the write() returned zero or -EFOO.
The current code is simply buggy, but got lucky.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/