Re: [PATCH 17/38] groups: move code to kernel/groups.c

From: Serge E. Hallyn
Date: Tue May 26 2009 - 19:23:03 EST


Quoting Alexey Dobriyan (adobriyan@xxxxxxxxx):
> On Tue, May 26, 2009 at 09:48:19AM -0500, Serge E. Hallyn wrote:
> > Quoting Alexey Dobriyan (adobriyan@xxxxxxxxx):
> > > Move supplementary groups implementation to kernel/groups.c .
> > > kernel/sys.c already accumulated quite a few random stuff.
> > >
> > > Do strictly copy/paste + add required headers to compile.
> > > Compile-tested on many configs and archs.
> > >
> > > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> >
> > Actually I needed the following change:
>
> This is dealt by first patch:
> "[PATCH 01/38] cred: #include init.h in cred.h"
> which is in -mm already.
>
> > --- a/kernel/groups.c
> > +++ b/kernel/groups.c
> > @@ -1,6 +1,7 @@
> > /*
> > * Supplementary group IDs
> > */
> > +#include <linux/init.h>
>
> Wrong, groups.c doesn't use __init at all.

Right you are.

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/