Re: [2.6.27.24] Kernel coredump to a pipe is failing

[Andrew Morton]

On Tue, 26 May 2009 22:31:41 +0200
Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Block signals during core dump
> 
> When a signal happens during core dump the core dump to a pipe 
> can fail, because the write returns short, but the ELF core dumpers
> cannot handle that.
> 
> There's no reason to handle signals during core dumping, so just
> block them all.
> 
> Open issue: ELF puts blocked signals into the core dump and
> that will be always fully blocked now.  Need to save it somewhere?
> 
> Based on debugging by Paul Smith.
> 
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

dump_write() doesn't seem right, either.  If ->write() returns, say,
100 then the dump should keep on going.  At present it treats this
return as an error.

I wonder why the signal problem has just turned up now - did we change
the pipe code or something?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/