Re: [PATCH 1/3] kernel.h: Add DO_ONCE statement expression macro

[Andrew Morton]

On Thu, 21 May 2009 16:00:22 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:

> +/*
> + * Do something once (analogous to WARN_ONCE() et al):
> + */
> +#define DO_ONCE(x...) ({			\
> +	static bool __done = false;		\
> +						\
> +	if (!__done) {				\
> +		x;				\
> +		__done = true;			\
> +	}					\
> +})

Every single call site for this macro will be mind-bogglingly ugly and
complex callers won't look like C at all.

It would be much better to replace

	DO_ONCE(code-sequence);

with
	if (ONCE()) {
		code-sequence;
	}

I think that's fairly natural and clear and will allow us to clean up a
large number of callsites many of which do the same thing in different
ways, some of them buggily.

And yeah, if this is to be core kernel infrastructure then the default
implementation shouldn't be racy on SMP/preempt.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/