Re: [RFC PATCH 3/X] ptrace: introduce the empty "structptrace_task"

[Oleg Nesterov]

On 05/25, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > --- PTRACE/include/linux/sched.h~3_STRUCT	2009-05-24 21:29:04.000000000 +0200
> > +++ PTRACE/include/linux/sched.h	2009-05-24 22:14:41.000000000 +0200
> > @@ -1201,6 +1201,7 @@ struct task_struct {
> >  	struct list_head sibling;	/* linkage in my parent's children list */
> >  	struct task_struct *group_leader;	/* threadgroup leader */
> >
> > +	struct ptrace_task *ptrace_task;
> >  	/*
> >  	 * ptraced is the list of tasks this task is using ptrace on.
> >  	 * This includes both natural children and PTRACE_ATTACH targets.
>
> the naming sucks.
>
> Please use 'struct ptrace_context' and '*ptrace_ctx' instead.

As always, I agree with any naming. Will re-name in V2.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/