Re: [GIT PULL] scheduler fixes
From: Pekka Enberg
Date: Mon May 25 2009 - 07:38:16 EST
On Mon, May 25, 2009 at 2:25 PM, Nick Piggin <npiggin@xxxxxxx> wrote:
>> @@ -576,6 +576,22 @@ asmlinkage void __init start_kernel(void)
>> setup_nr_cpu_ids();
>> smp_prepare_boot_cpu(); /* arch-specific boot-cpu hooks */
>>
>> + build_all_zonelists();
>> + page_alloc_init();
>> +
>> + printk(KERN_NOTICE "Kernel command line: %s\n", boot_command_line);
>> + parse_early_param();
>> + parse_args("Booting kernel", static_command_line, __start___param,
>> + __stop___param - __start___param,
>> + &unknown_bootoption);
>> + /*
>> + * Setup kernel memory allocators
>> + */
>> + pidhash_init();
>> + vmalloc_init();
>> + vfs_caches_init_early();
>> + mem_init();
>> + kmem_cache_init();
On Mon, May 25, 2009 at 2:25 PM, Nick Piggin <npiggin@xxxxxxx> wrote:
> Looks quite OK to me. The comment above maybe misleading?
>
> The bootmem allocations of course are required because some hashes may
> need to be larger than MAX_ORDER without using vmalloc.
>
> kmem_cache_init (and mem_init, partially) sets up the kernel memory
> allocators...
Which comment are you talking about? The "setup kernel memory
allocators" one? Yeah, I should probably move it couple of lines down.
It's just that we absolutely need to do the other ones before calling
mem_init() and then kmem_cache_init().
On Mon, May 25, 2009 at 2:25 PM, Nick Piggin <npiggin@xxxxxxx> wrote:
> I can take a look at the SLQB side.
Great!
Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/