Re: [PATCH 3/7] percpu: clean up percpu variable definitions

[Rusty Russell]

On Wed, 20 May 2009 05:07:35 pm Tejun Heo wrote:
> Percpu variable definition is about to be updated such that
>
> * percpu symbols must be unique even the static ones
>
> * in-function static definition is not allowed

That spluttering noise is be choking on the title of this patch :)

Making these pseudo statics is in no way a cleanup.  How about we just
say "they can't be static" and do something like:

/* Sorry, can't be static: that breaks archs which need these weak. */
#define DEFINE_PER_CPU(type, var) \
	extern typeof(type) var; DEFINE_PER_CPU_SECTION(type, name, "")

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/