Re: [PATCH] rtc: add x86 support for rtc-efi

[Huang Ying]

On Tue, 2009-04-21 at 02:21 +0800, Anvin, H Peter wrote:
> Ingo Molnar wrote:
> > * Brian Maly <bmaly@xxxxxxxxxx> wrote:
> > 
> >>> Hm, it would be nice to first unify the relevant bits of 
> >>> arch/x86/kernel/time_{32|64}.c into arch/x86/kernel/time.c, and 
> >>> then we can apply such patches without duplicative effects.
> >> Ingo,
> >>
> >> Are you OK with consolidating this into arch/x86/kernel/rtc.c as 
> >> Huang Ying had suggested? This seems like the most logical place 
> >> for the rtc-efi init to happen, but your suggestion to consolidate 
> >> this into arch/x86/kernel.time.c may have advantages that I am not 
> >> aware of.  Anyway, I would appreciate any insight/opinions on this 
> >> if you have any.  Thanks.
> > 
> > Yes, that indeed sounds like an even better place for it.
> > 
> 
> Furthermore, the EFI RTC code probably should be in its own file.
> 
> In fact, arch/x86/kernel really could use more subdirectories; at least 
> the EFI and UV-specific code should be be moved out.

Or, do you think it is appropriate to re-organize EFI related code into
a sub-architecture?

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/