Re: [PATCH 1/1] signal: make group kill signal fatal

[Oleg Nesterov]

On 05/24, Jiri Slaby wrote:
>
> __fatal_signal_pending() returns now true only for a non-group sent
> sigkill, i. e. for example tgkill, send_sig...

No. Please look at complete_signal(). If we queue a fatal signal,
we always add SIGKILL to any thread.

> Use sigkill_pending()

Please do not use it, it should die.

> in __fatal_signal_pending() which adds a test also
> for shared_pending queue.

See above. Afaics this is not needed.

> Also grab siglock in __fatal_signal_pending().

This is wrong. It can be called when the task has already died
and its ->signal == NULL.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/