Re: [PATCH 3/4] ide: respect quirk_drives[] list on all controllers

[Sergei Shtylyov]

Hello.

Bartlomiej Zolnierkiewicz wrote:

> > > * Add ide_check_nien_quirk_list() helper to the core code
> > >  and then use it in ide_port_tune_devices().

> > > * Remove no longer needed ->quirkproc methods from hpt366.c
> > >  and pdc202xx_{new,old}.c.

> >    Haha, I remembered about that idea of yours and was thinking of 
> > undertaking its implementation just yesterday. You've beten me to it. :-)

> Sigh, if I knew I would concentrate on other things...

> I did it only because there is outstanding ide-pmac bugreport probably
> related to one of these quirky drives...

   Yes, I figured. :-)

> > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

> > Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

> > > Index: b/drivers/ide/ide-iops.c
> > > ===================================================================
> > > --- a/drivers/ide/ide-iops.c
> > > +++ b/drivers/ide/ide-iops.c
> > > @@ -269,6 +269,31 @@ no_80w:
> > > 	return 0;
> > > }
> > >
> > > +static const char *nien_quirk_list[] = {
> > > +	"QUANTUM FIREBALLlct08 08",
> > > +	"QUANTUM FIREBALLP KA6.4",
> > > +	"QUANTUM FIREBALLP KA9.1",
> > > +	"QUANTUM FIREBALLP KX13.6",
> > > +	"QUANTUM FIREBALLP KX20.5",
> > > +	"QUANTUM FIREBALLP KX27.3",
> > > +	"QUANTUM FIREBALLP LM20.4",
> > > +	"QUANTUM FIREBALLP LM20.5",
> > > +	NULL
> > > +};
> > > +
> > > +void ide_check_nien_quirk_list(ide_drive_t *drive)

> >    Why not reuse ide_in_drive_list()?

> Should have been in patch #5/4 but I ran out of time, I will do it later
> unless you would like to handle it...

   I'm looking at the unification of ack_intr()/clear_irq() now and making 
the former usable for the PCI drivers too...

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/