Re: [PATCH/RFC 2.6.29.2] Driver for CB710/720 memory card reader(MMC part) - v4

From: Pierre Ossman
Date: Fri May 22 2009 - 07:28:19 EST


On Fri, 8 May 2009 17:16:22 +0200
MichaÅ MirosÅaw <mirq@xxxxxxxxxxxx> wrote:

> Here is next version of the CB710 SD/MMC reader driver. As in previous
> versions the code is divided in two parts - virtual 'bus' driver that
> handles PCI device and registers three new devices one per card reader
> type. The other device handles SD/MMC part of the reader.
>
> Key changes from v3:
> - kerneldoc for sg_mapping_iterator extension
> - free/restore IRQ during suspend/resume
> - protect slot->irq_handler by spinlock instead of RCU
> - remove verify_serialization()
> - Kconfig
> - complete patch for linux kernel 2.6.29.2
>

Looks good to me. I just want you to add a MAINTAINERS entry so that
people know who to contact if they have problems with this driver.

> My patches for sg_mapping_iterator extension went to /dev/null, so I have
> incorporated them to the cb710 core driver module for now. Probably someone
> with more karma points should look at them (sgbuf2.{c,h}) and push further
> if they are of any value to other driver writers.

Give them to Andrew Morton. He's good at finding the right people and
making sure they notice. :)

Rgds
--
-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

Attachment: signature.asc
Description: PGP signature