Re: [PATCH 2/5] ide: ->ide_dma_clear_irq() -> ->clear_irq()

[Sergei Shtylyov]

Hello, I wrote:

> > > * Rename ->ide_dma_clear_irq method to ->clear_irq
> > >   and move it from ide_hwif_t to struct ide_port_ops.

> > > * Move ->waiting_for_dma check inside ->clear_irq method.

> > > * Move ->dma_base check inside ->clear_irq method.

> > > piix.c:
> > > * Add ich_port_ops and remove init_hwif_ich() wrapper.

> > > There should be no functional changes caused by this patch.

[...]

> >   It may also be worth considering turning this method into 
> > test-and-clear, so that we can get the actual IDE interrupt state on 
> > the chips that implement this...

>   Probably might add the test_irq() method to be called on 
> !hwif->waiting_for_dma. Cleraing the status at once seems impractical...

   Yet this seems what ack_intr() method is doing already...
   What it does is testing IRQ status and "acknowledging" it (the semantics 
of "acknowledge" is not clear to me, yet it seems that it's clearing the 
interrupt latch in the drivers where it's implemented). And the call site of 
ack_intr() method corresponds to where test_irq() should have been called, 
so it seems we don't need yet another method and probably didn't even need 
clear_irq() method in the first place?..
   Bart, could you clarify about how ack_intr() is supposed to work?

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/