Re: [PATCH 1/3] tracing: add __print_flags for events

From: Christoph Hellwig
Date: Wed May 20 2009 - 18:59:38 EST


On Wed, May 20, 2009 at 06:13:37PM -0400, Steven Rostedt wrote:
> OK, this may even save space. By passing by parameters we must load all
> the parameters before calling the function. Even though this is on the
> print side, it is still bloated. I'll convert it to an array.

Nice, thanks.

Btw, it would be nice to add a __print_symbolic cousin that looks for
an exact match in an array. That way we can also print translations to
names in a way that can be read from the format file and duplicated
by userspace apps using the binary trace buffer.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/