Re: [PATCH] sysrq: Don't panic_on_oom if the user requested an OOM kill.

[Bodo Eggert]

David Rientjes <rientjes@xxxxxxxxxx> wrote:
> On Mon, 18 May 2009, Geoffrey Thomas wrote:

>> If I specifically request an OOM kill via magic sysrq, I don't want
>> panic_on_oom to apply and crash the machine. I ran into this on a server
>> with panic_on_oom and automatic reboot after panic configured on the
>> assumption that nobody is likely physically present. If I'm able to use
>> magic sysrq, though, I can use that to reboot the machine slightly more
>> safely, if that's what I wanted.
>> 
>> This patch adds an extra parameter to out_of_memory to ignore the value
>> of sysctl_panic_on_oom, and just proceed with the OOM kill.
>> 
>> Signed-off-by: Geoffrey Thomas <geofft@xxxxxxx>
> 
> Nack, it's your own fault for asking for panic_on_oom and then not wanting
> it to panic on oom.
> 
> Disable /proc/sys/vm/panic_on_oom before invoking the oom killer and then
> reenable it afterwards.

Did you even think about the reasons for pressing sysrq-foo?
Like - e.g. - NOT BEING ABLE TO LOG IN?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/