Re: [PATCH] Fix print out of function which called WARN_ON()

From: Arjan van de Ven
Date: Mon May 18 2009 - 10:12:04 EST


Ian Campbell wrote:
On Sat, 2009-05-16 at 13:47 -0700, Linus Torvalds wrote:

- it uses '%pS' instead of of sprint_symbol
[...]
- printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
- line, function);
+ printk(KERN_WARNING "WARNING: at %s:%d %pS()\n", file, line, caller);

Those parens end up looking pretty odd to me with the %pS:
WARNING: at [...] local_bh_enable+0x68/0x80()

didn't we have a %pSomething that doesn't print those 2 hex parts ?
(It would allow us to keep the print format the same)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/