[Xen-devel] Re: [GIT PULL] xen /proc/mtrr implementation

From: Jan Beulich
Date: Mon May 18 2009 - 09:17:26 EST


>>> Ingo Molnar <mingo@xxxxxxx> 18.05.09 10:59 >>>
>Here Xen invades an already fragile piece of upstream code
>(/proc/mtrr) that is obsolete and on the way out. If you want a
>solution you should add PAT support to Xen and you should use recent

As Jeremy pointed out a number of times, Xen *does* have PAT support,
perhaps (that's my personal opinion) even superior to the Linux one, as
it doesn't redefine the 486-inherited caching mode attributes but rather
uses the full 3 bits that the hardware provides (and, as an
acknowledgement to the various hardware bugs, makes sure not to use
any large page mappings when using non-WB mappings).

>upstream kernels. Or you should emulate /proc/mtrr in _Xen the
>hypervisor_, if you really care that much - without increasing the
>amount of crap in Linux.

As Jeremy also pointed out previously, emulating the MTRRs in the
hypervisor is very undesirable (and technically at least very close to
impossible), as we're talking about the *real* MTTRs that need managing
here (whereas dealing with virtualized MTRRs in a fully virtualized guest
is a completely different - and very reasonable - thing).

I can only support Jeremy in asking that you please reconsider your NAK.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/