Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock sourcesupport

[John Stultz]

On Sat, 2009-05-16 at 09:15 +0800, Wu Zhangjin wrote:
> On Fri, 2009-05-15 at 17:39 -0700, john stultz wrote:
> > On Fri, May 15, 2009 at 3:23 PM, Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:
> > > +static struct clocksource clocksource_mfgpt = {
> > > +    .name = "mfgpt",
> > > +    .rating = 1200,
> > 
> > Minor nit. Please read the comment over the struct clocksource
> > definition in include/linux/clocksource.h for a guide to setting the
> > rating value for your clocksource.
> > 
> 
> as the comment describes, just like the 8253 Timer, the precision of
> cs5536 mfgpt Timer is not good, the rating of it should be in the range
> of 100-199? Functional for real use, but not desired?

That would seem reasonable to me, as it insures that should better
clocksources become available on the hardware, it will pick the better
hardware.

But I'll leave the final call to you.

I just wanted to make sure we're all using the same scale, and 1200 was
off the charts ;)

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/