Re: [PATCH 4/5] x86: implement percpu_alloc kernel parameter

From: Jan Beulich
Date: Fri May 15 2009 - 04:04:33 EST


>>> Tejun Heo <tj@xxxxxxxxxx> 15.05.09 06:28 >>>
>@@ -395,6 +404,16 @@ out_free_ar:
> return ret;
> }
>
>+/* for explicit first chunk allocator selection */
>+static char pcpu_chosen_alloc[16] __initdata;
>+
>+static int __init percpu_alloc_setup(char *str)
>+{
>+ strncpy(pcpu_chosen_alloc, str, sizeof(pcpu_chosen_alloc) - 1);
>+ return 0;
>+}
>+early_param("percpu_alloc", percpu_alloc_setup);
>+
> static inline void setup_percpu_segment(int cpu)
> {
> #ifdef CONFIG_X86_32

Does this really need to be early_param()? setup_per_cpu_areas() runs
after setup_arch(), which is where the full command line parsing happens.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/