[PATCH 1/4] nilfs2: remove meaningless EBUSY case from nilfs_get_sb function

From: Ryusuke Konishi
Date: Fri May 15 2009 - 02:44:25 EST


The following EBUSY case in nilfs_get_sb() is meaningless. Indeed,
this error code is never returned to the caller.

if (!s->s_root) {
...
} else if (!(s->s_flags & MS_RDONLY)) {
err = -EBUSY;
}

This simply removes the else case.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
---
fs/nilfs2/super.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
index 6989b03..8131615 100644
--- a/fs/nilfs2/super.c
+++ b/fs/nilfs2/super.c
@@ -1172,8 +1172,6 @@ nilfs_get_sb(struct file_system_type *fs_type, int flags,

s->s_flags |= MS_ACTIVE;
need_to_close = 0;
- } else if (!(s->s_flags & MS_RDONLY)) {
- err = -EBUSY;
}

up(&sd.bdev->bd_mount_sem);
--
1.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/