Re: [patch 29/51] mac80211: pid, fix memory corruption

From: Jiri Slaby
Date: Fri May 15 2009 - 02:24:33 EST


Hi,

note that you were about to drop this one now because of waiting for a
fixup which is not upstream so far. Did anything change?

(This is the one which fixes a memory corruption, but triggers a bug
causing oopses on single band cards.)

On 05/15/2009 12:33 AM, Greg KH wrote:
From: Jiri Slaby <jirislaby@xxxxxxxxx>

commit 6909268dc93ae4b0b8e1ebb4b2fa70b1a47dd347 upstream.

pid doesn't count with some band having more bitrates than the one
associated the first time.
Fix that by counting the maximal available bitrate count and allocate
big enough space.

Secondly, fix touching uninitialized memory which causes panics.
Index sucked from this random memory points to the hell.
The fix is to sort the rates on each band change.

Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/