Re: [PATCH] TOMOYO: Add garbage collector support. (v2)

From: James Morris
Date: Thu May 14 2009 - 21:49:44 EST


On Thu, 14 May 2009, Tetsuo Handa wrote:

> ---
> security/tomoyo/common.c | 456 +++++++++++++++++++-----------------
> security/tomoyo/common.h | 134 ++++++++--
> security/tomoyo/domain.c | 437 +++++++++++++---------------------
> security/tomoyo/file.c | 369 +++++++++++++++--------------
> security/tomoyo/realpath.c | 567 ++++++++++++++++++++++++++++++++++-----------
> security/tomoyo/realpath.h | 25 +
> security/tomoyo/tomoyo.c | 40 +--
> security/tomoyo/tomoyo.h | 13 -
> 8 files changed, 1190 insertions(+), 851 deletions(-)

This seems like an awfully large and invasive patch just to add GC support
which you didn't originally didn't think was necessary.

I think it needs review from people outside of your project.


- James
--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/