Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V3

[Minchan Kim]

On Thu, May 14, 2009 at 11:27 PM, KOSAKI Motohiro
<kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
>> Âmm/vmscan.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index 2f9d555..621708f 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone,
>> Â Â Â Â * Even if we did not try to evict anon pages at all, we want to
>> Â Â Â Â * rebalance the anon lru active/inactive ratio.
>> Â Â Â Â */
>> - Â Â Â if (inactive_anon_is_low(zone, sc))
>> + Â Â Â if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0)
>> Â Â Â Â Â Â Â Âshrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
>
>
> Â Â Â if (nr_swap_pages > 0 && inactive_anon_is_low(zone, sc))
>
> is better?
> compiler can't swap evaluate order around &&.

If GCC optimizes away that branch with CONFIG_SWAP=n as Rik mentioned,
we don't have a concern.

-- 
Thanks,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/