Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to64 bits in X86_64

From: H. Peter Anvin
Date: Thu May 14 2009 - 10:10:43 EST


Andi Kleen wrote:
>> Well, I just think lots of "#ifdef/#else" is a little annoying here, then use
>> REX...
>
> Better add a 'q' string concatination then. The problem with rex is that most
> people can't read it even if they know assembler -- they don't know
> all the details of instruction encoding.
>

The right way to do it is to pass the proper type of register.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/