Re: [PATCH] ata: libata depends on HAS_DMA

From: FUJITA Tomonori
Date: Wed May 13 2009 - 20:21:09 EST


On Wed, 13 May 2009 17:57:14 -0600
Robert Hancock <hancockrwd@xxxxxxxxx> wrote:

> Alan Cox wrote:
> >>> If it doesn't interfere with plain PIO mode, fine.
> >> I agree. There definitely needs to still be support for IDE ports that
> >> don't have DMA capability.
> >
> > There is - it's just if the platform doesn't implement the dma_* APIs you
> > get a problem.
>
> Wouldn't the easiest solution be to just dummy out the DMA API calls on
> this platform to always fail? That would fix these compile problems..

Can libata call dma_supported() per device to decide DMA or PIO mode?
Then, we can solve this problem by add dummy DMA API (just calls BUG)
on such architectures, without Kconfig magic or adding ifdef (like the
old ide stack does), I think.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/