Re: jsm: two or more 4/8-port boards can not initialize ports properly

From: Alexander Y. Fomichev
Date: Wed May 13 2009 - 17:54:47 EST


On Wed, May 13, 2009 at 1:49 AM, Alexander Beregalov
<a.beregalov@xxxxxxxxx> wrote:
> 2009/5/13 Alexander Y. Fomichev <git.user@xxxxxxxxx>:
>> G' day
>>
>> The patch bellow fix for me problem with jsm_uart_port_init
>> which still thinking it works for 2-ports borads only.
>> drivers/serial/jsm/jsm_tty.c +462
>> brd->channels[i]->uart_port.line = brd->channels[i]->ch_portnum +
>> brd->boardnum * 2;
>>
>>                         ^^^^^^^^^^^^^^^^^^^^^^
>> so for line numbers of the second and further boards
>> may/will be assigned values with the same range.
>> in my case of two digi neo-8 -- 6 ports of 8 failed to be
>> added for the second board.
>
> Hi Alexander,
>
> Your patch is broken, your mail client wraps long lines.
> Please read Documentation/email-clients.txt.
> Please add linux-serial@xxxxxxxxxxxxxxx,
> alan@xxxxxxxxxxxxxxxxxxx and Scott.Kilau@xxxxxxxx to CC list.
> Please add Signed-off-by line as described in Documentation/SubmittingPatches

tnx for advise



--
Best regards.
Alexander Y. Fomichev <git.user@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/